Introduce CancellableContinuation.resume with onCancelling lambda #1084
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested changes
Apr 12, 2019
kotlinx-coroutines-core/common/src/CancellableContinuationImpl.kt
Outdated
Show resolved
Hide resolved
* Allows safe return of closeable resources from suspending functions, as it provides a way to close a resource if the corresponding job was cancelled. * Documentation on the context and expected behavior of CompletionHandler implementations is updated. Fixes #1044
elizarov
force-pushed
the
resume-cancelling
branch
from
24ef1b1 to
3af2596
Compare
qwwdfsad
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions, as it provides a way to close a resource if the
corresponding job was cancelled.
CompletionHandler implementations is updated.
Fixes #1044